cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

admission: Split stats for WorkQueueMetrics

Open andrewbaptist opened this issue 2 years ago • 1 comments

This commit splits the WorkQueueMetric stats into priority. Because there are a lot of new stats that might be generated as a result of this splitting, only the "important" priorities are collected and considered for each queue.

Release note: None

andrewbaptist avatar Sep 16 '22 22:09 andrewbaptist

This change is Reviewable

cockroach-teamcity avatar Sep 16 '22 22:09 cockroach-teamcity

bors r=irfansharif

andrewbaptist avatar Sep 27 '22 19:09 andrewbaptist

Build succeeded:

craig[bot] avatar Sep 27 '22 21:09 craig[bot]

This patch increased the number of timeseries exported to tsdb by crdb nodes from 731 to 1739. If there's histograms in there, it might be even much worse for Prometheus. I don't think we can afford anything like it...

andreimatei avatar Sep 30 '22 20:09 andreimatei

I was concerned about the impact of this change. I can easily disable all of these and will hold off on any backporting. I might need to rethink if there is a way to get the data we want without exploding stats.

andrewbaptist avatar Sep 30 '22 20:09 andrewbaptist

I think I fooled myself when counting, sorry. I now think that this patch only took the timeseries count from 1543 to 1739. So, now quite as bad as I thought. Still significant, though.

andreimatei avatar Sep 30 '22 20:09 andreimatei