Andreas Karis
Andreas Karis
The code for `helm dep update` that's in charge of this is here: https://github.com/helm/helm/blob/e87f81563788f311e7a5a7640385c003d5d6096b/pkg/downloader/manager.go#L243 and that calls findChartURL: https://github.com/helm/helm/blob/e87f81563788f311e7a5a7640385c003d5d6096b/pkg/downloader/manager.go#L689 It then uses `DownloadTo` to download the chart: https://github.com/helm/helm/blob/e87f81563788f311e7a5a7640385c003d5d6096b/pkg/downloader/manager.go#L355 These methods...
I'm not a maintainer here, either. I'm just looking into helm and I'm chasing for some low-hanging fruit bug reports. I changed it a bit and I think its cleaner...
@mattfarina Done With current master: ~~~ [akaris@linux helm-upstream]$ git log --oneline | head -1 eb994345 Merge pull request #9871 from mattfarina/logging-for-creds [akaris@linux helm-upstream]$ make make: Nothing to be done for...
Sorry for having been MIA on this PR. Seems like @felipecrs addressed some of the points here already but that conflicts must be resolved ... I'm sure that either he...
(let me try to refresh my PR, add felipecrs's changes, and then join the helm meeting) - I'll report back here
FYI, I put this PR onto Thursday's agenda and will join the community call and ask about the maintainers' opinion
Hello @mattfarina, as discussed during the helm meeting last Thursday, can I get a review for this, please? I'm o.k. making modifications or if this is a new feature or...
@gjenkins8 I rebased this to match your changes, can you review, pls?
I had joined the helm meeting in Feb and someone promised to look at it, but since then, unfortunately, nothing has happened review wise :(
@haircommander https://github.com/cri-o/cri-o/pull/9405 merged now, so I guess it's time to revisit this one, here :-)