Andreas Karis
Andreas Karis
Hi, Is there anything else that needs to be done to move this forward? Our customers are being affected by the lack of retries in helm (https://bugzilla.redhat.com/show_bug.cgi?id=1934604) and I'd like...
Sorry, my bad, I thought you were a member of the project :-) Thanks for reviewing this, then. @bacongobbler What are the next steps? :-)
Hi, Apart from this and the master branch having diverged, how does the helm project deal with upstream contributions? Because this pull request has been open for 3 months now....
I rebased it again and I also sent an email to Matt. With that said, I'm totally open to changes (especially to the unit tests), so please let me know...
@felipecrs Would that implementation do it? By the way, why isn't your script simply using `helm pull repo.Name/chart` instead of `helm pull --repo repo.URL chart`?
I'm at a loss here: If a a user added a repository with a username and password with helm repo add, then this very repository is close to 100% sure...
But everything reads the repo's local cache directly, it's where tha password, repo name, repo url and username come from.
What currently happens when helm pull is run: look up the repo cache entry by name, return the first entry found, get the URL, get the username, get the password...
To do: Have to fix conflict in unit test due to missing: https://github.com/cri-o/cri-o/commit/4409a15f667612b44eb8cf4f7c7b220ac647bd84#diff-bc25e15e13072e3a8ff7fc6a28ab46835c3051e5dca571380e110210c1edabae ``` 3m 12s Run golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 prepare environment run golangci-lint Running [/home/runner/golangci-lint-1.60.3-linux-amd64/golangci-lint run] in [/home/runner/work/cri-o/cri-o] ... internal/runtimehandlerhooks/default_cpu_load_balance_hooks_linux.go:1: :...
/hold I found another issue with race conditions and other pieces must be fixed upstream before merging this