Results 78 comments of Andreas Karis

I think we can close this, Martin already worked on another patch but the partner went silent wrt the initial issue and I don't want to make a change for...

@MouliBurla can you check if this is something that would make sense? Thanks!

Looks o.k. to me but I'm horrible at reviewing without actually testing the code. If I have time I'll test this tomorrow, but IMO this looks simpler (and thus better)...

I'm trying to reproduce https://issues.redhat.com/browse/OCPBUGS-29648 or https://github.com/k8snetworkplumbingwg/whereabouts/issues/176 with upstream/master whereabouts on kind, to get a baseline for my testing. I can reproduce OCPBUGS-29648 on OCP 4.14, but I cannot reproduce...

I just tested the `reboot --force` scenario from https://issues.redhat.com/browse/OCPBUGS-29648 manually and everything works for me with the fix. WRT attaching the same network 2x: ``` 25 template: 26 metadata: 27...

Does the repository have some documentation for how to write and run unit tests? I'd like to cover this in a test :-) So I'd like to simulate a 409...

> Hey there! I noticed that you mentioned several other projects that came to the same conclusion. Because of that I’m curious if this is code you wrote yourself or...