Andrea Barontini

Results 11 comments of Andrea Barontini

> Maybe it's better to get the changed cut back into master ASAP, to limit the number of affected fits. Could you open a separate PR for it? Yes sorry,...

As we discussed during the code meeting, in this case we have certain point prescriptions that are not compatible with all the theoryids than you can use (so either 200...

@comane thanks for this. If you want, ask myself for the review (but also add one between @scarlehoff and @RoyStegeman given that part of this PR is based on my...

> This is then ready to be merged? (@andreab1997 @comane ) I don't think so, surely I need to review this again but in any case I would wait for...

> This piece is complete and already rebased on top of master isn't it? If so it should be merged, worst case scenario you can note down the checksum of...

> Hi @andreab1997, I addressed most of the comments that you left, as well as those that I wrote myself. > > There is one main issue with this PR...

> > Just to understand, this issue is only there if you use the CLI or even if you write your own runcard and template? > > I think it's...

Thank you for this! I am going to review it soon

And, last comment, one of the test is broken, do you understand why? I believe that rebasing on master could solve the issue

@comane I don't know if you addressed the points in my review. If you did, can you please paste the relevant commits as a comment in the relevant sections? (I...