nnpdf icon indicating copy to clipboard operation
nnpdf copied to clipboard

Published 20 hours ago • verified publisher icon NNPDF

Introduction of an inconsistency within a Closure Test

Open comane opened this issue 2 years ago • 3 comments

The purpose of this PR is to study the effects of introducing data inconsistencies within a Closure Test.

comane avatar Feb 28 '23 16:02 comane

Thank you for this! I am going to review it soon

andreab1997 avatar Feb 28 '23 17:02 andreab1997

And, last comment, one of the test is broken, do you understand why? I believe that rebasing on master could solve the issue

andreab1997 avatar Mar 23 '23 14:03 andreab1997

@comane I don't know if you addressed the points in my review. If you did, can you please paste the relevant commits as a comment in the relevant sections? (I know it is a pain but it makes reviewing a bit easier :) )

EDIT: same for @giovannidecrescenzo of course

andreab1997 avatar May 23 '23 10:05 andreab1997