Aart van Baren

Results 333 comments of Aart van Baren

@filiptronicek When a namespace is created, the user that issued the command becomes a contributor to the namespace. https://github.com/eclipse/openvsx/blob/df28c16c4d919afaf1c8795ab0dfabd842ceb6e6/server/src/main/java/org/eclipse/openvsx/LocalRegistryService.java#L436-L446 Once the namespace has been created, you need to be a...

> Does that mean that @open-vsx is a contributor to all namespaces on open-vsx.org? No, @open-vsx is only a contributor to all namespaces it created. It can publish to all...

From [Namespace Access](https://github.com/eclipse/openvsx/wiki/Namespace-Access): > A warning icon ⚠️ is shown for some extensions, along with a hint that the publishing user is not verified. There are multiple situations that can...

- [X] Add a condition to `isVerified` where if the user is a privileged user, then it's always verfied. - [ ] Update [Namespace Access](https://github.com/eclipse/openvsx/wiki/Namespace-Access) to reflect the change in...

It looks like the MS marketplace doesn't include any WebResources in the response. ``` curl --location --request POST 'https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json;api-version=3.0-preview.1' \ --data-raw '{"filters":[{"criteria":[{"filterType":8,"value":"Microsoft.VisualStudio.Code"},{"filterType":12,"value":"4096"}],"pageNumber":1,"pageSize":50,"sortBy":4,"sortOrder":0}],"assetTypes":[],"flags":950}'...

And looking at the blame info, AssetTypes hasn't changed in the past 5 years: https://github.com/microsoft/vscode/blame/cc86b15a44fe28300180108f4d95cacee98717dc/src/vs/platform/extensionManagement/common/extensionGalleryService.ts#L190-L207 It was introduced in openvsx in PR #262: https://github.com/eclipse/openvsx/pull/262/files#diff-17aa6856a7169de1018e7f3a9db6305371243d8c52fcb023f4d063a8bcf977bc

@jeanp413 When I run ``` curl 'https://open-vsx.org/vscode/gallery/extensionquery' \ -H 'accept: application/json;api-version=3.0-preview.1' \ -H 'content-type: application/json' \ --data-raw '{"filters":[{"criteria":[{"filterType":8,"value":"Microsoft.VisualStudio.Code"},{"filterType":12,"value":"4096"}],"pageNumber":1,"pageSize":50,"sortBy":4,"sortOrder":0}],"assetTypes":[],"flags":950}' \ --compressed ``` the response no longer contains web resources. [extensionquery.json.txt](https://github.com/eclipse/openvsx/files/10066229/extensionquery.json.txt)

@christian-bromann No updates on this. The openvsx server has some performance issues that need to be addressed first. I've developed a fix, but these changes still need to be tested...

@zlweicoder You can refactor this constant to an application property, so that it becomes configurable in `application.properties`. Then use `@Value` to use the property in a `@Component`. You can find...

@zlweicoder Could you open a pull request (PR) containing the changes you've made?