openvsx icon indicating copy to clipboard operation
openvsx copied to clipboard

[Admin] Add Ability to Change Namespace

Open amvanbaren opened this issue 3 years ago • 3 comments

Fixes #427

Added change namespace dialog to the webui Added /admin/change-namespace endpoint to server TODO: invalidate caches after namespace change.

Testing steps

  • Navigate to admin dashboard
  • Search for a namespace
  • Click the 'Change namespace' button
  • A dialog opens up
  • Type a new namespace name and check/uncheck the options
  • Click the 'Change namespace' button in the dialog to perform the operation

amvanbaren avatar Jun 09 '22 09:06 amvanbaren

Really looking forward to this 👏

christian-bromann avatar Jun 22 '22 21:06 christian-bromann

@amvanbaren any updates on this?

christian-bromann avatar Aug 11 '22 12:08 christian-bromann

@christian-bromann No updates on this. The openvsx server has some performance issues that need to be addressed first. I've developed a fix, but these changes still need to be tested on staging. You can follow progress here: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1483

amvanbaren avatar Aug 11 '22 12:08 amvanbaren

@filiptronicek I've had this issue when changing the user's role while the user is still logged in. Log out and then log in again should solve the problem.

amvanbaren avatar Jan 06 '23 08:01 amvanbaren

Question: is it intended that I see the namespace controls twice? image

filiptronicek avatar Jan 06 '23 14:01 filiptronicek

Same priority as #427

kineticsquid avatar Jan 17 '23 18:01 kineticsquid

Question: is it intended that I see the namespace controls twice? No, I've removed the top namespace members section.

amvanbaren avatar Feb 02 '23 09:02 amvanbaren

@amvanbaren feature seems to work well, I could rename a namespace, everything was instantly updated to reflect it. Also tried keeping the old namespace, everything was removed but the namespace stayed as intended.

I have some UI suggestions that could be applied:

image psd(3)

What does "Keep old 'redhat' namespace" mean?

To keep means to not remove the namespace at the end of the namespace change. We can change it to Remove old 'redhat' namespace and check it by default.

What happens if the namespace exists and "Abort the process if new namespace already exists" is not checked?

It merges the namespace into the already existing namespace. If it is checked then it returns an error: "New namespace already exists: 'name'" and no changes are made. Instead we could show a warning dialog: "New namespace Y already exists. Do you want to merge namespace X into namespace Y?"

amvanbaren avatar Feb 02 '23 09:02 amvanbaren