Aart van Baren

Results 333 comments of Aart van Baren

The `/vscode/gallery/extensionquery` endpoint mirrors the responses returned by the same visualstudio marketplace endpoint. So we can't reduce the size by changing the request or response for this endpoint. The request...

I've removed compression from https://github.com/eclipse/openvsx/pull/412. https://github.com/eclipse-theia/theia/issues/10538#issuecomment-1028912793 proposes paging for the `/api/-/query` endpoint by using `offset` and `size` query parameters in the same way as the `/api/-/search` endpoint.

Thanks @ccorn for your thorough analysis. There are multiple endpoints that return a response with the `allVersions` property set: -`/admin/extension/{namespaceName}/{extensionName}` -`/api/{namespace}/{extension}` -`/api/{namespace}/{extension}/{targetPlatform}` -`/api/-/publish` -`/api/-/query` Only the `/api/-/query` endpoint returns multiple...

> I just found that mime types are listed in the [Content_Types].xml file inside the vsix 🤦 So we just need to parse it and use the rules in there....

> can we merge this so it's shipped in next deployment 🙂 Yes, I'll rebase and complete this PR. > BTW, can you share until which commit got deployed? Up...

> @amvanbaren let's merge 🙏 @jeanp413 Has this been reviewed and tested?

This PR is missing a migration: https://github.com/eclipse/openvsx/issues/468#issuecomment-1323388969

![Schermafbeelding 2022-06-23 om 10 21 17](https://user-images.githubusercontent.com/14129099/175252301-84930003-9893-43d1-a0d8-ca1e515cf743.png) We could only show the orange warning banner if the logged in user is the publisher of the extension, so that they can take...

Maybe add a new publisher category, e.g. 'trusted reposter'?

> Do these accounts exist apart from @open-vsx? I don't know. My guess is that the @open-vsx user is the same as the `super_user` account on dev. It's probably easier...