amquake
amquake
> - test signs of pitch/yaw are still right That should be tested here, no? https://github.com/PhotonVision/photonvision/blob/534d00f8520a689d977e11bea7f63077263cf36a/photon-core/src/test/java/org/photonvision/vision/target/TargetCalculationsTest.java#L71-L88
Ah, yea. The `testYawPitchBehavior()` test I linked seems to have it right regardless, though. Does addressing my first comment fix that issue in `testYawPitchCalc()` then-- reverting the sign changes in...
Not sure if this constitutes a new issue, but on a similar note the FOV could also be automatically determined from a valid calibration instead of the entry in the...
I'm going to close this as (at least largely) completed with the recent simulation overhaul and visualization options. Features described in this post that differ from the current implementation: -...