Amir Mehr

Results 8 comments of Amir Mehr

Thanks folks for the contribution here, can you please just lint the code with ruff config that we have to pass the checks?

@isaacbmiller thank you for the review and comments. I have added it to recommended `Suggested Checklist` for templates and I think we should at some point deprecate it.

I agree, but still the PR is a draft till I talk with @okhat

hey folks, just a follow up on this one, should we close this pull request?

I just merged the main into the branch but seems like lots of conflicts, I resolved most of them based on my own knowledge but please take another look at...

@isaacbmiller @okhat folks should I merge the master with this or we should wait on this one for now?

There are some merge conflicts in pyproject and poetry and I think after that we should be good to go.

> > Great job! Thank you for your time and contribution! Overall, this looks good to me, but here are a few suggestions: > > > > 1. It would...