dspy icon indicating copy to clipboard operation
dspy copied to clipboard

Remove top_p default value

Open xdite opened this issue 4 months ago • 3 comments

Pratically, we should not use top_p and temperture at the same time, however, we may override temperture in some cases, but since DSPy predefine top_p = 1, it's impossible to leave top_p as blank.

this weired behavior is due to there are very diffrent results from direct openai call V.S. DSPy.

xdite avatar Apr 03 '24 02:04 xdite

Thanks @xdite . Yes ideally, we can remove these definitions and have users define all the model kwargs directly (some models are not compatible with frequency_penalty, presence_penalty, etc.) but tagging @okhat to verify this won't break any existing caches with GPT3?

arnavsinghvi11 avatar Apr 04 '24 18:04 arnavsinghvi11

This will break existing caches. Maybe this can somehow be marked as "for next breaking release" and then merged in the future.

But I don't understand the need for this. Can't the user just pass None? Why can't we specify top_p and temperature at once? What's the effect of this PR?

okhat avatar Apr 10 '24 16:04 okhat

hey folks, just a follow up on this one, should we close this pull request?

ammirsm avatar Apr 16 '24 15:04 ammirsm