Amin Ya

Results 1114 comments of Amin Ya

Something strange is happening here: https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=340&view=logs&j=0c24d9d5-0e27-5404-37e0-91cb4d692d0c&t=3786b6db-cb02-5fcf-294f-324dd576bffa Although all the tests have passed, the code has exited with `0` number.

> hmm 🤔 the only thing I can think is if there is an async call that isn't awaited and fails. so the test finishes with async functions still running...

There should be no difference here. I am just using the same Jasmine 1 using the new Jasmine 3 runner. 🤔 There is no async call in the tests themselves...

I found why the tests fail here. https://github.com/UziTech/atom-jasmine3-test-runner/issues/166 (fixed) and https://github.com/UziTech/atom-jasmine3-test-runner/issues/167 (hopefully will be fixed) are the two of the reasons.

We're going to add Terminal: https://github.com/atom-community/terminal

> > Autocomplete seems broken > > Can you give an example? I'm using these modifications for a whole week now, and did not find any issues (well, I _am...

Cherry-picked #417. We should fix the failing tests (there are a lot) before we can merge this.

> It references "vscode" in the github repository name. Those are not for Atom. Tree-sitter is editor agnostic.

npm 7 or newer is not supported yet. #402 fixes this.

We will get this kind of error in the first installation, and it will happen again during updating. So I don't think codesign is a determining factor here.