atom icon indicating copy to clipboard operation
atom copied to clipboard

➡️ Migrate all language packages + Bump Tree Sitter

Open aminya opened this issue 3 years ago • 7 comments

Continuation of #403 and #399. Please read the descriptions of those PRs first.

aminya avatar Jul 01 '22 21:07 aminya

Autocomplete seems broken

Can you give an example? I'm using these modifications for a whole week now, and did not find any issues (well, I am using the version that I bumped Electron too, but I'm not sure if this could change things this much)

mauricioszabo avatar Jul 03 '22 04:07 mauricioszabo

Autocomplete seems broken

Can you give an example? I'm using these modifications for a whole week now, and did not find any issues (well, I am using the version that I bumped Electron too, but I'm not sure if this could change things this much)

See the failing tests. HTML, Java, and Ruby have changed. Tree-sitter is the grammar of Atom, and changing it is actually a big deal.

aminya avatar Jul 03 '22 04:07 aminya

Cherry-picked #417. We should fix the failing tests (there are a lot) before we can merge this.

aminya avatar Jul 03 '22 04:07 aminya

By the way, tree-sitter-typescript v19.x or newer doesn't build on Windows, in my testing.

https://github.com/tree-sitter/tree-sitter-typescript/pull/146#issuecomment-817022548 ^ Related comment that explains when the build failure started, I think?

DeeDeeG avatar Jul 11 '22 02:07 DeeDeeG

There is a list of working tree-sitter packages here:

https://github.com/cursorless-dev/vscode-parse-tree/blob/4936a9c78b4e5aa3ad99816dfa751b00c5d9abd9/package.json#L78-L103

We should update all the outdated dependencies with these. This will probably fix the build issues.

It references "vscode" in the github repository name. Those are not for Atom.

ghost avatar Jul 18 '22 21:07 ghost

It references "vscode" in the github repository name. Those are not for Atom.

Tree-sitter is editor agnostic.

aminya avatar Jul 18 '22 23:07 aminya

It references "vscode" in the github repository name. Those are not for Atom.

Tree-sitter is editor agnostic.

@aminya I made this fork specifically for Atom Community https://github.com/stechness/atomcommunity-parse-tree.

ghost avatar Jul 19 '22 01:07 ghost