Amin Ya
We still have cache misses: https://dev.azure.com/atomcommunity/atomcommunity/_build/results?buildId=117&view=logs&j=2985f0af-e798-5fdc-91b8-be9f0a3685c5&t=d0984c8c-0243-5740-7c87-f72756b34e5a&l=36
I removed bootstrap skipping in https://github.com/atom-ide-community/atom/pull/33/commits/6413b1591f491cc044776c06223cad99734be80b. If we want to use cache when we change package.json, etc, we need to remove this line.
> If we get an exact cache restore for all three, then we do want to skip bootstrapping IMO. > > It would be a plain win to revert that,...
> Maybe we can cache Windows build tools and dependencies... I'm just afraid we're going to have nothing but 39 cache steps pretty soon. Those don't take much time. I...
@DeeDeeG We can set a pull request trigger for the master branch. That should be possible in Azure UI.
> Should it be in a separate PR if I get it working? OK Sure, Make a PR to this branch (always_restore_cache). We can see if it speeds up the...
@DeeDeeG So are you sure that if we change package.json, the bootstrap step is not skipped here?
@DeeDeeG bump. If the answer is yes, I want to merge this.
The PR is made by the main author of Atom. I can't complain. 😄 I think the reason is to prevent MSBuild to build the native apps. https://github.com/atom/atom/blob/09e4af2d99f0c488face9888af6dde602d95e344/script/lib/delete-msbuild-from-path.js#L14
@DeeDeeG ~~In the renderer tests (tests affected by this pull request), `apm` is not detected for some reason. Should we put it on the path?~~ This is fixed in Jasmine3...