Andrew McCreight

Add documentation for how to check out beta

4

I'm sure this just demonstrates that I have no idea how cinnabar actually works, but I am unable to figure out (based on "Mozilla: A git workflow for Gecko development"...

failure to parse weak maps line in GC log

1

bkelly got this, I think from a win64 GC log: Parsing gc-edges.9092.1464365140.log. Error: unknown line WeakMapEntry map=00000218C5CBE0C0 key=0000021896D58DF0 keyDelegate=0000000000000000 value=00000218AA005BC0

Right now the scripts look for paths from the rooting objects, but there's no reason a user couldn't just specify a random object if they are trying to understand the...

It should probably just scan all arguments looking for the gc- or cc- prefix rather than requiring it is the first one.

Switch scripts to optparse

1

Some of the scripts use this, which has been deprecated since Python 2.7, which is the minimum version to build Firefox, so I think it is reasonable to require it.

A string in the GC log like 'foo\n' gets recorded as having a length of 5, but the last character is actually '\n', not 'n', so the length should be...

Right now, the weak map support in find_roots is not that great. Doing it right would be hard, but it could at least be improved by tracing through the key...

Or at least objects with a hojillion fields.