Alejandro Candioti
Alejandro Candioti
Oh wait I added the Dijkstra's change by mistake! This PR was only intended to have the benchmark changes. The speed up I was referring to is from the already...
Fixed! I reverted uninteded changes
@rossbar I changed the worst case graph generation. You can see how it generates the worst case where all edges produce a new relaxation (https://github.com/networkx/networkx/pull/8218#issuecomment-3251428033). Let me know if you...
Friendly ping! It would be great to merge this one so we track the benchmarks used for shortest paths algos
I don't see anything obvious on the edit distance code. It is computing distance matrices by comparing all pairs. Any chance you can produce a minimal code snippet to repro?...
> I can try to make it smaller. I left snippets in so I could make sure I could guarantee that it reproduced. > > > It is computing distance...
Q: is your comparison function consistent? Do you get f(a, b)==f(b, a) for any a and b? Not sure if it matters here but it could
Can you replace all the complex logic for the score by a hardcoded function? That would ease reviewer's work to understand the issue
I don't necessarily see a problem with the order of nodes changing What I meant by a hardcode value is replacing the function by a dictionary with the evaluation for...
Your substition cost function is triggering a corner case for the algorithm where it detects it has the same "cost" to perform an insertion operation than edit. Here is a...