Alejandro Candioti
Alejandro Candioti
> Maybe we should add an example to that general recommendation. Something like: > ```python > old_wts = nx.get_edge_attributes(G, "weight") > new_wts = {e: round(1e8 * wt) for e, wt...
I think it's better to replace the current Kruskal implementation than add a new one that is faster. I don't see the value of having both
> I ran some ablations based on your feedback: > > * `upstream_main`: current NetworkX main. > * `upstream_main+early_break`: upstream plus early exit at lines 275,282. > * `upstream_main+early_break+custom_dsu`: adds...
Interesting, so speed up comes from using early stop and doing path halving in union-find data structure. I missed the path halving thing before! I'm +1 on and adding the...
Very cool, thanks for the benchmarks @rossbar !
You should pass keys=True to edges as opposed to data=True. These subgraphs are constructed as views that "filter" the underlaying graph. So you don't need to pass the data, it...
Thanks! Some of these ideas I tried when working on https://github.com/networkx/networkx/pull/8191 but I didn't get significant results (some of the improvements could have been just noise). Note that we only...