Jan Amann

Results 436 comments of Jan Amann

Great, let me know how it goes!

Hi @lipp, Glad to hear you're liking the package! I think eventually this package might be deprecated in favour of [Server Components support in Next.js](https://nextjs.org/blog/layouts-rfc), so I'm currently not planning...

@derberg Strange, I must have closed the PR by accident 🤦‍♂️. I've just reopened it. There was [one comment remaining](https://github.com/amannn/action-semantic-pull-request/pull/194/files#r928786431), other than that the PR would be fine.

Hi @omnomnomka and thank you for your PR! This looks pretty good. Can you add some tests and fix the lint error that is reported on CI? Thanks! 🙌

I have the same issue. My current workaround is to keep track of the already fetched pages in a ref and ignore calls to `fetchMore` if the page is already...

I have a use case that might be related to this. ```js import React from 'react'; import Button from 'components/Button'; import config from './config'; import styles from './ErrorBoundaryError.scss'; ``` In...

What's the status of this? Looks like this PR was approved and the only thing left to do is to copy over the bugfix mentioned above.

Is there something missing for this PR to get merged? I also encountered the problem described in the referenced issue.

@alexzherdev That's great to hear! Thank you so much for your help! It's really cool to have auto fixable `jsx-sort-props` and `sort-prop-types`. After that, there's only auto fixing for `jsx-sort-default-props`...

@alexzherdev Not sure if that's an option, but since even the test suite on master fails for that version, would it be an option to bump the peer dependency of...