eslint-plugin-react
eslint-plugin-react copied to clipboard
jsx-eslint
[New] `sort-prop-types`: support comments on prop types
Hmm appveyor actually failed (node 5 choked on args spread somewhere inside eslint), but there's a green check here.
Is there something missing for this PR to get merged? I also encountered the problem described in the referenced issue.
@amannn I will be tackling https://github.com/yannickcr/eslint-plugin-react/pull/1973#discussion_r247757333 within a few days
@alexzherdev That's great to hear! Thank you so much for your help!
It's really cool to have auto fixable jsx-sort-props and sort-prop-types. After that, there's only auto fixing for jsx-sort-default-props missing for me to go all-in on sorting props 🙂.
Haven’t had time to get back to it yet. The issue in https://github.com/yannickcr/eslint-plugin-react/pull/1973#discussion_r215113449 is a tricky one to make sense of.
@alexzherdev Not sure if that's an option, but since even the test suite on master fails for that version, would it be an option to bump the peer dependency of eslint to 3.18.0?
Would be a shame if the support for that version would block helpful contributions like this PR. ESLint 3.0.0 was released on July 1, 2016 – that's three years ago. Even node.js LTS releases have a stop of maintenance after 3 years.
@amannn no, that'd be a breaking change.
Surely there's a way we can handle eslint 3.0 - even if that means gracefully degrading to the behavior prior to this PR.
@alexzherdev I'm going to disable the entire autofix behavior of this rule before the next release unless we can find a way to get this PR in; it'd be great if you had time to update this.