eslint-plugin-react
eslint-plugin-react copied to clipboard
Add sort-default-props and deprecate jsx-sort-default-props
Pt. 1 of #1834
~Looks like I need to fix #1817 to improve coverage.~ ~Edit: done~
Just rebased to resolve conflicts
If my PR is merged before yours, you'll have to add my bug fix. https://github.com/yannickcr/eslint-plugin-react/pull/2182
@alexzherdev Since my PR https://github.com/yannickcr/eslint-plugin-react/pull/2182 was merged, you have to update the new sort-default-props, or you'll lose the fix I made.
Thanks ;)
What's the status of this? Looks like this PR was approved and the only thing left to do is to copy over the bugfix mentioned above.
ping @alexzherdev
Done
This looks good, but I'm going to cut a patch release before merging semver-minor items.
Codecov Report
Merging #1861 (feae3bc) into master (c3d3e25) will decrease coverage by
0.04%
. The diff coverage is91.04%
.
@@ Coverage Diff @@
## master #1861 +/- ##
==========================================
- Coverage 97.63% 97.58% -0.05%
==========================================
Files 123 124 +1
Lines 8988 9055 +67
Branches 3288 3308 +20
==========================================
+ Hits 8775 8836 +61
- Misses 213 219 +6
Impacted Files | Coverage Δ | |
---|---|---|
index.js | 100.00% <ø> (ø) |
|
lib/rules/sort-default-props.js | 90.00% <90.00%> (ø) |
|
lib/rules/jsx-sort-default-props.js | 91.04% <100.00%> (+1.04%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.