eslint-plugin-react icon indicating copy to clipboard operation
eslint-plugin-react copied to clipboard

Add sort-default-props and deprecate jsx-sort-default-props

Open alexzherdev opened this issue 6 years ago • 7 comments

Pt. 1 of #1834

alexzherdev avatar Jun 29 '18 06:06 alexzherdev

~Looks like I need to fix #1817 to improve coverage.~ ~Edit: done~

alexzherdev avatar Jun 29 '18 06:06 alexzherdev

Just rebased to resolve conflicts

alexzherdev avatar Jul 24 '18 17:07 alexzherdev

If my PR is merged before yours, you'll have to add my bug fix. https://github.com/yannickcr/eslint-plugin-react/pull/2182

VincentLanglet avatar Feb 28 '19 22:02 VincentLanglet

@alexzherdev Since my PR https://github.com/yannickcr/eslint-plugin-react/pull/2182 was merged, you have to update the new sort-default-props, or you'll lose the fix I made.

Thanks ;)

VincentLanglet avatar May 20 '19 07:05 VincentLanglet

What's the status of this? Looks like this PR was approved and the only thing left to do is to copy over the bugfix mentioned above.

amannn avatar Jul 05 '19 13:07 amannn

ping @alexzherdev

ljharb avatar Jul 05 '19 22:07 ljharb

Done

alexzherdev avatar Jul 06 '19 05:07 alexzherdev

This looks good, but I'm going to cut a patch release before merging semver-minor items.

ljharb avatar Sep 30 '22 20:09 ljharb

Codecov Report

Merging #1861 (feae3bc) into master (c3d3e25) will decrease coverage by 0.04%. The diff coverage is 91.04%.

@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
- Coverage   97.63%   97.58%   -0.05%     
==========================================
  Files         123      124       +1     
  Lines        8988     9055      +67     
  Branches     3288     3308      +20     
==========================================
+ Hits         8775     8836      +61     
- Misses        213      219       +6     
Impacted Files Coverage Δ
index.js 100.00% <ø> (ø)
lib/rules/sort-default-props.js 90.00% <90.00%> (ø)
lib/rules/jsx-sort-default-props.js 91.04% <100.00%> (+1.04%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 30 '22 23:09 codecov[bot]