Adrian Macneil

Results 204 comments of Adrian Macneil

There are two ways to integrate dbmate into an existing schema: **1) Do nothing, start using dbmate going forward** You can simply start using dbmate, and add/edit your existing schema....

Hmm, that's annoying. So is the connectionLimit param specific to mysqljs? Dbmate is designed to "just work" with your existing connection url, so I could be convinced that we should...

The other option is instead of a list of supported parameters, we could just strip this one parameter and any others that people come across. That way you will still...

What are you trying to achieve? If you don't define a down migration (or add a no-op statement as you propose) then I believe dbmate will still remove record of...

Let's keep this issue open, I think it would be nice to explicitly fail when attempting to rollback a migration if no down migration is defined, rather than pretending that...

Sounds good. I like the behavior of graceful shutdown on first signal and hard exit on second. We should probably handle SIGTERM the same way, I don't know what our...

This would add a lot of complexity to dbmate, and I'm not convinced that it is necessary. In a typical software development workflow, it's easy to avoid this situation by...

I don't think this is currently possible. Would you expect this behavior to be the default or behind some sort of `--verbose` flag?

I've looked into the sql statement splitting before too. From memory it's required in order to implement a spanner driver, since the existing spanner driver doesn't support multiple statements. It...

Well, we could print that `Result`, but it looks like the only fields it exposes are `LastInsertId` and `RowsAffected`, neither of which would be particularly useful or address the need...