Adrian Macneil

Results 204 comments of Adrian Macneil

I would consider this ticket narrower scope, a one time comparison of new3d vs old3d. For https://github.com/foxglove/studio/issues/956 we should create a framework & infrastructure for evaluating the whole studio app...

Copying thoughts from Slack thread: Something like playback a file "as fast as possible" and calculate the p50/p90/p99 frame render times would probably be sufficient. Do this for old3d vs...

Can we generate a scene that stresses both panels more?

Feedback: - No need to implement support for changing the selected variable ID (wait and see if anyone asks for it) - Set `$selected_id` to `null` after I deselect an...

I agree it's a caveat of the CLI rather than MCAP itself. So we should note it in the CLI docs. However, I think we should move the CLI docs...

Maybe rather than “fix” could use the term “recover”. The implication is that we are working with a corrupt file, so we will do our best to recover it and...

I think we could create some new groups for `X axis` and `Y axis` (or google sheets calls them `Horizontal axis` and `Vertical axis`):

👍 The next step after this is to start adding back our own context menu where it makes sense. https://vscode.dev/ is a good example of this done well imo (browser...

I don't think it should be a CLI flag. We need to do a bit more research, but my understanding of ROS 2 is that each publisher/subscriber can choose to...

Looks nice. @ljburtz FYI this was your request. X axis settings currently seem pretty broken in this PR: https://user-images.githubusercontent.com/637671/185045022-2f6592d2-5f07-4c90-a9be-861e70896928.mov