Adrian Macneil

Results 207 comments of Adrian Macneil
trafficstars

Which version of dbmate are you using?

That's definitely not intentional. I don't have time to investigate right now, but it should be possible to run multiple statements with `transaction:false`. I'm fairly sure this used to work,...

Interesting. There is probably another way to achieve this. From memory that was the best way I could find to get a quoted array of identifiers. But I'm open to...

I think if you use [v1.11.0](https://github.com/amacneil/dbmate/releases/tag/v1.11.0) this particular issue won't occur, since it seems related to the custom `--migrations-table` option introduced in v1.12. I'm happy to accept a PR fixing...

How are you envisaging the batch is declared? I think this could be partially solved by https://github.com/amacneil/dbmate/issues/18 (migrating or rolling back to a specific migration). I'm not sure of the...

I think the fresh connection for each migration solution sounds ok. Are there any other downsides to this approach? We already open a fresh transaction for each migration, so I...

Definitely sounds like a bug. I don't have time to investigate right now, but I have a feeling it's probably something to do with our migration parsing logic in https://github.com/amacneil/dbmate/blob/main/pkg/dbmate/migration.go#L57...

Unfortunately I haven't found a way to get more useful error messages or line numbers. The `psql` has some smarts here which I think are implemented client side, and don't...

@silbinarywolf thanks! I will respond in the PR thread.

Last time I looked into this, I ran into the issue that dbmate has been designed around an assumption that all drivers will use `database/sql`, and the spanner driver did...