Andrew Lygin

@SomeoneToIgnore , fixed

I see the problem, but I don't know a good soluton either. It looks like all the editors use the same approach (the one implemented in this PR). > to...

@ConradIrwin, thank you for the feedback! Your ideas made me play a bit more with alternative implementations, and rethink a couple of edge cases. > The component would store the...

> I'm not sure what you mean by "change modifiers without releasing them"? I mean the case when I press `cmd-p`, keep holding `cmd`, then add `shift` to it (which...

> @alygin do you want to push up the work we did today to this branch or close this one and send another? I've added tests for common use cases...

Fixed: #9785

> I assume most vim users, and even non-vim users, use `escape` to close the search bar. `escape` sometimes doesn't work for closing the search bar, btw. For instance, in...

It looks like `escape` is not supposed to close the buffer searchbar in terminal: https://github.com/zed-industries/zed/blob/45d217f6e0a209999007aee0d7ee2914a5677021/assets/keymaps/default-macos.json#L651

Hi Thorsten! > @iamnbutler is back in a few weeks as our main designer, so I'm wondering whether we shouldn't wait until he has taken a look here. What do...

> We could make it themable though, so you can override it to make it transparent. In VSCode it's `editorGroup.border`. I didn't find its analogue in Zed.