zed icon indicating copy to clipboard operation
zed copied to clipboard

Add a setting to show/hide the project panel button in the status bar

Open baldwindavid opened this issue 1 year ago • 3 comments

What?

A setting has been added to control the visibility of the Project Panel button in the status bar.

Why?

I don't tend to use the Project Panel, but use a keyboard shortcut to access if needed. Thus, the button in the status bar provides me little more than visual clutter. Additionally, there is precedent for this configurability with other panels (collaboration, chat, notification, terminal, etc).

Release Notes:

  • Added a setting to show/hide the Project Panel button in the status bar. {"project_panel": {"button": false}}

baldwindavid avatar Apr 18 '24 01:04 baldwindavid

We require contributors to sign our Contributor License Agreement, and we don't have @baldwindavid on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Apr 18 '24 01:04 cla-bot[bot]

@cla-bot check

baldwindavid avatar Apr 18 '24 01:04 baldwindavid

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Apr 18 '24 01:04 cla-bot[bot]

Thanks @SomeoneToIgnore - Quite a bit is now hideable, but at least the following remains:

Screenshot 2024-04-18 at 5 31 31 PM Copilot button: Setting features.copilot: false will hide it, but believe that disables the entire service. I think this might be the only interface into the Copilot service so I can understand why it's there currently, but perhaps it could have a copilot.button: false setting that would only hide the button if the user is signed in to Copilot.

Screenshot 2024-04-18 at 5 38 57 PM Tab Bar Actions: #7356 would make this moot for those that hide the tab bar completely, but these should probably be hideable either as a group or separately. Either that or a setting (e.g. tab_bar.quick_actions) that defaults to ["new", "split", "zoom"] and could support other potential buttons in the future or be empty to hide.

Screenshot 2024-04-18 at 5 41 32 PM Buffer Search Bar Close Button - I assume most vim users, and even non-vim users, use escape to close the search bar. Seems like this could either be configured to never be displayed or only on hover within the search bar area similar to the "x" on tabs.

baldwindavid avatar Apr 18 '24 21:04 baldwindavid

I assume most vim users, and even non-vim users, use escape to close the search bar.

escape sometimes doesn't work for closing the search bar, btw. For instance, in the Terminal pane:

  1. Open the Search bar.
  2. Get back to the command line.
  3. Execute any command, echo abracadabra will do.
  4. Hit escape

Searchbar is still there.

I don't know the exact steps to reproduce it for the editor, but the same problem exists there too.

alygin avatar Apr 21 '24 05:04 alygin

@alygin I'm not able to reproduce that. Regardless, I think I will open up separate issues for each of these three items that are not yet hideable.

baldwindavid avatar Apr 25 '24 01:04 baldwindavid

It looks like escape is not supposed to close the buffer searchbar in terminal: https://github.com/zed-industries/zed/blob/45d217f6e0a209999007aee0d7ee2914a5677021/assets/keymaps/default-macos.json#L651

alygin avatar Apr 29 '24 11:04 alygin

Oh, I totally misunderstood the issue you mentioned there. Until now I did not realize a buffer search could even be opened in a terminal. I thought you were saying the search in an editing pane could not be closed after some interaction with the Terminal.

Anyway, yeah, since the Terminal is effectively always in INSERT mode that behavior is expected to me. But if Zed supported Alacritty's vi mode (#7417) I'd expect escape to close the buffer search in that mode.

baldwindavid avatar Apr 29 '24 12:04 baldwindavid