Andrew Lygin

Results 102 comments of Andrew Lygin

Given that Zed now has Tab Switcher, what other prerequisites must be met so we could allow the user to hide tabs?

@maxdeviant, thanks for the info! Done.

> It is great work, though again, I hope that the tabs might be moved to the title-bar in the future. This is because the title-bar is always there and...

@mikayla-maki, do you think something like Open Editors in VS Code or Open Files in Sublime Text will work? A toggable view in the Project Panel. In Zed it could...

> As for bottom tabs... I'd like to see some examples of this and proof this is something that a large number of people want before we consider adding it....

@mikayla-maki, since we're removing the `bottom` option, shouldn't we make this setting a simple boolean flag, like `show: true`?

> The only thing that took me a bit by surprise was that the tabs display in a project search. @baldwindavid, fixed

> Let's do that. Generally, I like to prefer enums to booleans. But also, the phrasing of `placement: none` is a little awkward. `show: true` tells the story well. Done

> What about worktrees addition/deletion, the new code would not react to that? Good point. No, it wouldn't. But I don't understand, in which practical cases this will be a...

> I think this could be simplified by subscribing to events on the project, instead of observing it. I believe the file finder only needs to update on the ‘WorktreeUpdatedEntries’...