Alya Abbott

Results 1722 comments of Alya Abbott

> I guess there was some misunderstanding here. I was thinking of simple select elements which we originally used inside the modal and not `dropdown_list_widget`. Sorry, what do these two...

Oh, I see, I somehow missed that in the screen capture. Yes, it should definitely be a `select` element!

Thanks! Let's make sure the dropdown has however much horizontal space it needs to fit the text (within the window). It's a bit short even in English, but we should...

I also notice that this still needs to happen: > Replace the "Retain for N days after posting" option with "Custom"

Can we also change the message retention policy selector in the "Create stream" UI to match the one we're implementing here?

I also noticed and filed #23274, but that can be handled separately.

> we could just add a single save-discard widget for now and then probably have some meaningful sections once we add more stream settings as per https://github.com/zulip/zulip/issues/19525 Agreed! Actually, this...

Hm, how are we validating the custom fields? I don't think it's quite working right: ![Screen Shot 2022-09-22 at 12 18 38 PM](https://user-images.githubusercontent.com/2090066/191832882-de822281-bc9c-4fa6-bbbd-4796cf2e4efd.png) Clicking "Save changes" in this state sets...

Hmm, this is a good start, but I guess we're missing an explanation of how *not* to mark messages as read automatically.