Alya Abbott
Alya Abbott
I responded above -- thanks!
@akarsh-jain-790 please leave a comment when @sahil839 's comments have been addressed.
I put the above note verbatim into https://github.com/zulip/zulip/issues/22537, but let's hold off on actually working on this pending the discussion in https://chat.zulip.org/#narrow/stream/101-design/topic/move.20.2F.20edit.20message.20UI.
Will uploading banners be a short-term follow-up? We really need to fix the fact that the current coloring looks totally out of place in dark theme.
Playing with this briefly: 1. Has dark theme not been implemented yet? I see:  2. Also, in the above screenshot, the spacing...
3. When the text goes to multiple lines, the vertical spacing at the top and bottom looks too small to me. @terpimost is this as you intended? ![Screen Shot 2022-09-14...
A couple of comments from playing with the PR: 1. I noticed that some banners have different margin on the left than others, which seems odd: 2. Something about this...
> Those all look like old banners! I'm not sure why you're not seeing the new ones. Two of the ones you're screenshotting are in my screenshots above 🤔 Hmm,...
Hmm, testing this again, I'm not seeing the warning for mentioning a private stream.
Otherwise looks good in my non-comprehensive manual testing. :)