Alya Abbott

Results 1722 comments of Alya Abbott

settings: Add initial implementation for custom welcome bot message.

Thanks! As indicated in the issue, the custom message should be a separate message.

settings: Add initial implementation for custom welcome bot message.

Also, the field label doesn't match the description in the issue: > Add a "Message text" text box field

settings: Add initial implementation for custom welcome bot message.

Let's rename the option for consistency with others: > Send a custom Welcome Bot message to new users

settings: Add initial implementation for custom welcome bot message.

Also, it should be next to "Send emails introducing Zulip to new users", so let's move that option down to be right above this one.

settings: Add initial implementation for custom welcome bot message.

For the message itself, let's drop the "also": > The administrators for this organization would like to share the following information: And let's try putting the admin comment in a...

settings: Add initial implementation for custom welcome bot message.

Ah, I meant putting the custom message into a ```quote block, not the intro text.

settings: Add initial implementation for custom welcome bot message.

Thanks! @prakhar1144 are you up for reviewing this one?

message-editing: include stream icon in message sent and visibility notification banners

Thanks for the fix! Could you please update your commit message to match the [commit style guidelines](https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages)?

message-editing: include stream icon in message sent and visibility notification banners

Please also complete the self-review checklist (as applicable), and post a comment to request a review when ready.

message-editing: include stream icon in message sent and visibility notification banners

Thanks! The horizontal spacing in your screenshots looks quite a bit off to me. What's the relationship between this PR and #20562, where we previously worked on this?