Alex Bilger

[Core] Make some functions non-virtual

9

They are not meant to be overriden because there is another mechanism to have a custom class name or template name. As stated in the removed comments, it should have...

[Helper] Deprecate error-prone resize and add emplace_back

2

resize(Size s, bool) is error-prone because of a similar function in std::vector but with different behavior: resize(size_type count, const value_type& value). See https://en.cppreference.com/w/cpp/container/vector/resize ______________________________________________________ By submitting this pull request, I...

[Core] STL parallelism support

5

Introduce flags to know if STL parallelism is supported (see https://github.com/sofa-framework/BeamAdapter/pull/50), and an example on how to use it. ______________________________________________________ By submitting this pull request, I acknowledge that **I have...

The following scenes must be fixed because they show warnings or error messages. ``` [INFO] [PluginFinder] Found 6 files with advice: examples\Benchmark\Performance\MatrixAssembly\MatrixAssembly_direct.scn examples\Components\linearsolver\preconditioner\FEMBAR_PCG_AsyncSparseLDLSolver.scn examples\Components\loader\GIDMeshLoader.scn examples\Components\solver\EulerExplicitSolver\EulerExplicitSolver.scn examples\Components\solver\EulerExplicitSolver\EulerSymplecticSolver.scn examples\Components\solver\NewmarkImplicitSolver.scn [INFO] [PluginFinder] Found...

`Data::getValue` has an overhead compared to a direct data access. If `getValue` is called millions of times, it can lead to a significative performances loss. An easy task is to...

ExternalBehaviorModel depends on SofaGraphComponent (https://github.com/sofa-framework/sofa/tree/master/applications/collections/deprecated/modules/SofaGraphComponent) which is deprecated. ExternalBehaviorModel is not deprecated, so we have a non-deprecated plugin depending on a deprecated plugin.

In https://github.com/sofa-framework/SofaPython3/blob/master/bindings/Sofa/package/__init__.py, the code checks the existence of files relative to `SOFA_ROOT`. However, on Windows, the bin folder is not `sofa_root + "\\bin"`, but `sofa_root + "\\bin\\"`. For example `bin/RelWithDebInfo`,...

Depends on https://github.com/sofa-framework/sofa/pull/2554 Since an intermediate node is created, the path from the root Node is no longer valid

Fix Python manual timing example

1

According to the user guide, when manual timing, it is necessary to explicit it by using the `UseManualTime` function. Its equivalent in Python is `use_manual_time()`. This function was not called...

[Type] Clean and test MatSym

1

A bit of cleaning (formatting, removal of commented code, use of our friend `std::enable_if_t` etc) for `sofa::type::MatSym`. I added the `operator*` on matrices (symmetric and non-symmetric). I also added simple...