Lucian Mocanu

Not sure what issue we are trying to fix here. Default is the column default value (in the column definition in the create table statement), the one the is used...

Okay, I get it now :) I think it makes sense. I'm a bit surprised that `CURRENT_TIMESTAMP` was hard-coded in that place. Normally, this is driver dependent - `Driver.mappedDataTypes.updateDateDefault` has...

Nice, @law108000. A test would be great to prevent this feature from breaking in the future.

The SAP tests fail because in HANA the timestamp precision must be between 1 and 7 (there's a different data type for precision 0), so creating the connection fails during...

Is this needed if `@implements {MigrationInterface}` is already in the class comment? I remember when types were added in jsdoc, they were kept to a minimum on purpose and telling...

It would be interesting to check the build, I would expect the code to transpiled the same way. I think we have synthetic default imports enabled in tsconfig, so I...

I think if the properties (columns) are explicitly named, TypeORM should always respect the user's choice and not rename anything (basically I see the current behavior as a bug), i.e.:...

I'll try tomorrow to take a look at the history of this `JunctionEntityMetadataBuilder.changeDuplicatedColumnNames` - I'd like to see why it was added. The current behavior is intentional, but I'd like...

I remember bun was implementing its SQLite API to be _as close as possible_ to `better-sqlite3`, so explicitly passing the driver might help. Would this work? ```ts import sqlite from...

@seepine The code that you wrote is correct. However, Bun does not implement the `Statement.reader` [property](https://github.com/WiseLibs/better-sqlite3/blob/master/docs/api.md#properties-1). I would suggest opening an issue for them. TypeORM uses `Statement.reader` to check if...