Lucian Mocanu

Results 149 comments of Lucian Mocanu

We plan to drop `gulp` completely, so this PR might not be needed. I will check when I'm at a computer.

@wy193777 You can already use `[email protected]` with `[email protected]` or even earlier. You don't need a new version of TypeORM for that. Also: we plan to drop `glob` too, we will...

We might need to create some additional tasks (for hashing + buffer), since it seems more complex than I initially thought. #### UUID I managed to replace `uuid.v4()` with `globalThis.crypto.randomUUID()`...

> Sometimes its much easier to put a function like CryptoUtils.sha() in the codebase and call it in case of missing global support Actually this is what I was also...

> it alone is responsible for nearly half of TypeORM's dependencies (33/81) @MatthiasKunnen this is why we planned it :) FYI we already replaced `glob` with `tinyglobby` like most other...

The corresponding PR did not implement topological sorting correctly. Currently, the tests for this are failing, so they will be skipped in PR #11801. Ideally, we should create an issue,...

So first of all, if there's any breaking change, we would like to do this in the next major version of TypeORM, which is developed in the `next` branch (instead...

@mag123c a few more things: the lockfile needs updating after `sha.js` was added back. Also the PR title should be updated. Looking at the source code of `uuid`, I also...

@pkuczynski I think here it's a problem of how we created the tasks, we should probably create 3 of them (shajs, uuid, and buffer), not just one :P However, if...

I would at least keep the latest Postgres (has the most tests) and maybe the latest MariaDB or MySQL and one of the SQLite tests. Would removing the CLI test...