Lucian Mocanu

Results 149 comments of Lucian Mocanu

Actually, TypeScript is already complaining about private members not being used. I could enable the `noUnusedLocals` option to make that an error, I would just be using tsc instead of...

Actually the compiler detects indexed access, but not across files. See `Car.wheels` in [codesandbox.io/s/agitated-ramanujan-vwpyxv](https://codesandbox.io/s/agitated-ramanujan-vwpyxv?file=/src/car.ts) - I set it up locally and ran `tsc --noUnusedLocals --noEmit src/*.ts` (the editor is a...

> I saw some config deprecations but I assume the pooling functionality is equivalent. So this is safe to include in a minor release, right? I tried to keep things...

Yeah, inserting default values is not supported by HANA 😜 I created this ticket while setting up the tests for HANA, these tests were failing. I'm not sure what can...

We merged #11310, should fix the original issue. Thanks for contributing :)

Using different node packages but the same compiler won't solve anything. Based on my limited experience trying to get the windows build working, I now realize why it is such...

@mikoloism Could you please fix the formatting? We updated to `[email protected]` in the meantime which formats a bit differently. Maybe you could also reduce the output of the command to...

@natenayya This an issue in your own repo, not in `exceljs` :) But one that `exceljs` should get rid of is `inflight` :)