Gui

Results 101 comments of Gui
trafficstars

well, no, it's not my misunderstanding: the way the information is linked is wrong. https://github.com/testground/testground#getting-started ![image](https://user-images.githubusercontent.com/2815267/166925014-ba33e3f6-b775-475e-a440-c02e89cc2297.png) instructs to do a vanilla `git clone` (not a particular tag v0.5.3) which results...

(btw thanks a lot @Bidon15 for clarifying the issue!! i'd never notice the little switch v0.5.3 -> master in gitbook otherwise)

FWIW, i did investigate this a bit in #418

#582 merged and fixed this

(i did include a trivial nitpick to ipfssync.go) :eyes:

thanks for the review! i did look for ways to avoid renaming and cleaner init'ing, but couldn't wrap my head around it. will try again :) and rework this PR....

yeah, i need to address all the points of the review and push a better version

took a first glance at code and it looks daunting to me AFAIU it's a race between a write originated at `vochain.(*BaseApplication).CheckTx()` (called by `vocone.addTx()`) and a read by `vochain.(*BaseApplication).DeliverTx()`...

so, my brain is melting but i'm dumping here what i understood so far: the read that is triggered by DeliverTx looks just fine, at `vochain/process.go:122` a v.Tx.RLock() is acquired:...