Gui
another race condition, different error but most likely can be solved in the same way. happened three times in a row: https://github.com/vocdoni/vocdoni-node/runs/7184212456?check_suite_focus=true#step:3:803 https://github.com/vocdoni/vocdoni-node/runs/7184330477?check_suite_focus=true#step:3:810 https://github.com/vocdoni/vocdoni-node/runs/7185082359?check_suite_focus=true#step:3:796 ``` 2022-07-04T16:33:05Z FATAL vochaintest/vochaintest.go:1735 submitRawTx failed:...
i'm debugging the second race condition, and yes, the underlying problem is the same: it's not trivial to "wait" for a transaction to be mined and be sure that it...
(i'm right now preparing a PR for this)
this is being adressed in #443
i've just noticed staticcheck gave `warning: "./..." matched no packages` in a run today https://github.com/vocdoni/vocdoni-node/runs/7675558159?check_suite_focus=true#step:7:13 and the step passed successfully (which i believe it shouldn't, since any actual staticcheck errors...
caught another occurrence of this same race: https://github.com/vocdoni/vocdoni-node/actions/runs/3131018883/jobs/5081913697#step:5:467 Stack trace ``` 2022-09-26T21:08:52.7439082Z 2022/09/26 21:07:38 OK 0001_create_table_processes.sql 2022-09-26T21:08:52.7440226Z 2022/09/26 21:07:38 OK 0002_create_table_votes.sql 2022-09-26T21:08:52.7441124Z 2022/09/26 21:07:38 OK 0003_alter_table_processes_votes.sql 2022-09-26T21:08:52.7441736Z 2022/09/26 21:07:38 goose:...
i spent a much more time than expected with this, and was about to desist, but then came up with #590 ironically it doesn't catch that particular log line, but...
well, nice enough, (and TBH unexpected! since it's happening on `go vet`) it did catch a couple of bugs. hurray! https://github.com/vocdoni/vocdoni-node/runs/7566037480?check_suite_focus=true ``` # go.vocdoni.io/dvote/ethereum/ethevents ethereum/ethevents/handlers.go:335:2: Debugf format %s reads arg...
going back to the original issue, i manually inspected the code with some keywords (things that are most likely []byte) ``` git grep 'log.' | grep -i hash git grep...
and many more with Fatal (which i initially did not touch) ``` # go.vocdoni.io/dvote/vochain vochain/app.go:496:4: Fatal call has possible formatting directive %s # go.vocdoni.io/dvote/client client/api.go:584:4: Fatal call has possible formatting...