Adam Porter

Results 2659 comments of Adam Porter

@basil-conto Good question, of course. Ideally we'd have both a unit test for the header parsing, and a test that actually receives non-UTF8-encoded content and verifies that it is decoded...

> Thanks for the review @basil-conto @alphapapa ! I added `case-fold-search` and rebased on top of master. > > I think a unit test would be good enough, since the...

Why did you close this issue? It seems like a good idea. I just don't have time to work on it right now.

Yes, given the nature of this library, I would prefer not to make any changes or additions without good tests to accompany them.

Some of the tests were already failing; see other issues/PRs here. But I don't recall which ones. The Org ones might depend on the version of Org you're using. And...

Thanks, but can't users already ignore warnings in their Emacs config? IIRC all you have to do is click on a link in the `*Warnings*` buffer.

Hi Joseph, As the FIXME indicates, I do want to resolve this, but at the same time, it was once added for a reason, so it needs to be done...

Hi Sacha, How great to have a contribution from you to one of my projects! :) For the property issue: we probably need to handle deferred property resolution now (this...