Andrew Longosz

Results 10 comments of Andrew Longosz

Hmm, this feature (as always) can go in `master` only. We also need to decide then to expose AttributeMapper as a strict contract, to be discussed with @ezsystems/php-dev-team how/where. Not...

@kmadejski what are the steps to reproduce here?

I need to investigate this deeper then, expected different outcome.

no worries, just a cs-fixer update. I'll let you know when I fix it :)

@vidarl @mateuszbieniek this one looks like a "low hanging fruit" mergabe without QA as it applies to code comment only. What is the status here? I see that this applies...

@ITernovtsiy unfortunately I cannot reproduce the issue on 2.5. I tried to adapt the code for 2.5 meta: https://github.com/ezsystems/ezplatform/compare/2.5...alongosz:review-2.5/ezp-31868-test-case For me embedded image on an error page (accessed via Symfony...

I'm gonna agree with @emodric on this :) But maybe we could just adjust the first line `# comment` in `parameters.yml.dist` to tell Developers where to look for the full...

@bdunogier I don't know much about GraphQL. Is it possible to keep here BC? Meaning when old query is passed, returning old result? We need to have a solution here.

@lserwatka of course, for this package itself, to be used by 3rd party, it is beneficial because exposes things available in Doctrine and provided OOTB by DBMS. I was just...

> > I still would recommend everyone to use named keys, but it's just a recommendation for 3rd party, requirement for us (IMO) > > Agreed, however this also means...