ezplatform-core icon indicating copy to clipboard operation
ezplatform-core copied to clipboard

Published 20 hours ago • verified publisher icon ezsystems

IBX-1021: Fixed database DSN string generation

Open kmadejski opened this issue 3 years ago • 6 comments

Question Answer
JIRA issue IBX-1021
Bug/Improvement yes
New feature no
Target version 2.3
BC breaks no
Tests pass yes/no
Doc needed no

TODO:

  • [x] Implement feature / fix a bug.
  • [x] Ask for Code Review.

kmadejski avatar Sep 15 '21 12:09 kmadejski

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 15 '21 12:09 sonarqubecloud[bot]

Ping @ezsystems/php-dev-team since I can't ask for review directly

kmadejski avatar Sep 15 '21 12:09 kmadejski

@kmadejski what are the steps to reproduce here?

alongosz avatar Sep 15 '21 13:09 alongosz

@kmadejski what are the steps to reproduce here?

I think an attempt to use DFS on Platform.sh would lead to this problem. I found it accidentally when I was about to reuse this piece of code for a different use case, hence no steps to reproduce in the ticket.

kmadejski avatar Sep 15 '21 14:09 kmadejski

@micszo thanks for testing. It is a kind of mystery to me then, as this fragment of code is supposed to generate DSN used later on by doctrine for establishing a connection to the DFS database. I think it is clear to all reviewers that the previous version is clearly wrong. Another question would be: why and how this is overwritten on the cloud so it works fine?

kmadejski avatar Sep 23 '21 08:09 kmadejski

I need to investigate this deeper then, expected different outcome.

alongosz avatar Sep 23 '21 09:09 alongosz