mapvizieR

mapvizieR copied to clipboard

documentation cleanup

1

cmd-check is failing - some mistakes in function docs that need to be tidied up: ``` * checking Rd \usage sections ... WARNING Undocumented arguments in documentation object 'adhoc_psuedo_quartile' 'x'...

almartin82

Change cgp_calc return values

1

Right now it returns both targets and results in a named list. I output should be controlled in a parameter

almartin82

read_cdf should flag likely problems

1

for instance, if students by school has dupes on studentid in the same term (ie, two different kids with studentid 0000) mapvizieR will fail. perhaps write a wrapper that is...

almartin82

internal consistency on start/end mean rit

2

In [summary](https://github.com/almartin82/mapvizieR/blob/e77e803978a853edb01b757e907d35b4d6651a2d/R/mapvizier_summary.R#L71) we call it `start_mean_testritscore`. In [cgp prep](https://github.com/almartin82/mapvizieR/blob/b262e71df77dded97c7903df69573d8e0a9a5df0/R/cgp_prep.R#L539) we call it `start_mean_rit'. Given that we're talking about the same calculation, we should probably pick one or the other. @chrishaid...

almartin82

growth_summary method is creating duplicate rows

1

 if there are any retained students in the data frame, summary() generates two rows for spring to spring - one with the main cohort, and one with the retained...

almartin82

NWEA doesn't provide formal norms for spring to winter, but I'm reasonably certain we could back into these expectations by looking at some combination of spring-spring, fall-spring, and fall-winter.

almartin82

@chrishaid I am looking over the codebase right now and sometimes we call things a plot, other times we leave plot off the end. My initial thinking is that we...

almartin82

nuke cgp_hist_plot in favor of alt_cgp_hist_plot

3

This is a breaking change, so I wanted to open it up for discussion before I did it. Right now cgp_hist_plot shows a cohort trajectory against the **average student percentile...

almartin82

verify cgp numbers

1

against known growth figures calculated by NWEA. might be related to #251, it feels like there's bad matching happening with the new norms?

almartin82

something is wrong with consistent_percentile

3

seems like it isn't matching on season?! 

almartin82