Eloy Durán

Results 250 comments of Eloy Durán

@kenotron Can we pair on this at some point?

Ah yes! This works: https://github.com/alloy/test-source-maps-with-typescript-through-babel/commit/a2982c8fe47eed4a0cf4a012a84411b191e854aa I was stepping through all the code looking for when the input and output maps of the generated code got merged and could only find...

> > Cococapods will move to Yaml eventually and I believe post processing hooks will be deprecated. > > Right, the process hook for the HockeySDK was done by @alloy...

It’s very kind of you to say so, thanks! :pray:

@cgatian Was there anything you had to do to make it actually work? Jest output is still not coloured for me.

This sounds like a great idea! I was thinking about something similar, but different, recently; which is to provide typed aliases of `commitMutation` in the generated artefacts such that you...

Currently we generate types for the [input variables and response](https://github.com/artsy/reaction/blob/175eeaf19ff585e346501365b1d24c2198770d51/src/__generated__/ArtistSearchResultsArtistMutation.graphql.ts#L4-L48), but casting `commitMutation` is left up to the user –currently I’m not even sure that `commitMutation` accepts the proper type...

Yeah right now `commitRelayModernMutation` doesn’t take any type parameters for either variables or response, so that needs to be fixed anyways.

I’m not sure I see how that would work, can you provide an example of the `commitMutation` function? The thing is that, unlike the `create*Container` functions, we never pass any...

Hmm, but the `mutation` parameter is supposed to be the GraphQL document, so it can’t exist in the artefact file.