Eloy Durán

Results 250 comments of Eloy Durán

An interesting note that came out of chatting to @ashkan18 was that this is only about knowing about the full schema, not whether or not a particular app/user may read...

@1aurabrown Would this have been the better fix for https://github.com/artsy/force/pull/418 ?

Yeah that does sound like a good initial step. I actually don't like at all that the client has to pass in a versions besides just the requested crop/fit size.

> because the area cropped is independent of how big the final image would be (for example, i could crop the upper right quadrant of an image, at various sizes,...

Shouldn’t this be done in Impulse? I think @joeyAghion even mentioned at some point that SendGrid (?) might provide a library to perform common sanitizations. Also, our of curiosity, do...

Good point, but that could just be separated from each other. Ideally we wouldn’t even add the “about this collector” stuff in the first place.

I like the idea in general, but also very much in the case of our infrastructure where counts seem inherently untrustworthy, e.g. a count returned from ES can still include...

Interesting. I agree that the pattern implemented in the end client at least makes a lot of sense and the one additional spinner the user might get to see isn’t...

Oh I see, yeah yeah I think you’re on the right track. Let’s give this a try And if this pans out it’s time to refactor and have our own...