Allison Chou
Allison Chou
[View Complete Diff of Changes](https://github.com/dotnet/fsharp/compare/0023c1584fa9063b18bd10ea3a507bd82262b5ea...7eb47e9f3dba867dbc9493c5a4297f88ac6b2edb?w=1) - [Streamlining some dependencies around Microsoft.CodeAnalysis (13637)](https://github.com/dotnet/fsharp/pull/13637) - [fix 13607 (13648)](https://github.com/dotnet/fsharp/pull/13648) - [RFC FS-1124 - Interfaces with static abstract methods (13119)](https://github.com/dotnet/fsharp/pull/13119) - [Include star in...
[View Complete Diff of Changes](https://github.com/dotnet/fsharp/compare/02452432ce5180092438b17df9c5788f0c1ba9cf...0023c1584fa9063b18bd10ea3a507bd82262b5ea?w=1) - [Remove net472 from FSharp.Compiler.Service (13532)](https://github.com/dotnet/fsharp/pull/13532)
[View Complete Diff of Changes](https://github.com/dotnet/fsharp/compare/ca24594be26d082204e1e351ed44d203b8bd0525...02452432ce5180092438b17df9c5788f0c1ba9cf?w=1) - [On arm64 vs default to platform specific compiler (13632)](https://github.com/dotnet/fsharp/pull/13632) - [Remove Cross_Platform_Compiler (13630)](https://github.com/dotnet/fsharp/pull/13630) - [Remove FX_NO_APP_DOMAINS (13603)](https://github.com/dotnet/fsharp/pull/13603) - [Consolidating TopVal and ValRepr terms (13624)](https://github.com/dotnet/fsharp/pull/13624)...
Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1909961 > Assert.Equal() Failure ↓ (pos 14) Expected: f.ToString Actual: f.ToSt ↑ (pos 14) Stack trace > at Roslyn.VisualStudio.IntegrationTests.InProcess.EditorVerifierInProcess.d__1.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorVerifierInProcess.cs:line 64 --- End of stack trace from previous...
Example build: https://dev.azure.com/dnceng/public/_build/results?buildId=1650954 Example message: > Assert.Equal() Failure ↓ (pos 0) Expected: FileImplementation.cs Actual: 'IBar' implementations - Entire solution ↑ (pos 0) > Actual and expected values differ. Expected shown...
Restore failure seen in https://runfo.azurewebsites.net/view/build/?number=1451898. Example log: > C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) Failed to retrieve information about 'Microsoft.VisualStudio.GraphModel' from remote source 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/825db618-e3eb-4426-ba54-b1d6e6c944d8/nuget/v3/flat2/microsoft.visualstudio.graphmodel/index.json'. at NuGet.Protocol.HttpFileSystemBasedFindPackageByIdResource.d__17.MoveNext() --- End of...
The [LSP spec](https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#textDocument_linkedEditingRange) indicates LinkedEditingRange can return either return `LinkedEditingRanges` or `null`. However, it seems like the O# ILinkedEditingRangeHandler expects a non-nullable response type: https://github.com/OmniSharp/csharp-language-server-protocol/blob/de1591e91a176fb88442ecf7e2e30f7a2174e6c0/src/Protocol/Features/Document/LinkedEditingRangeFeature.cs#L23
The LSP spec doesn't specify in what order semantic tokens should be returned (i.e. from highest -> smallest index or smallest -> highest index). This is causing issues in Razor...
### Summary of the changes - A formatting integration test [was being flaky](https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6436101) and running into a `TaskCanceledException`. - Turns out the problem was in our folding ranges logic. Essentially,...