razor icon indicating copy to clipboard operation
razor copied to clipboard

Make Razor and Roslyn LSP semantic ordering consistent

Open allisonchou opened this issue 4 years ago • 2 comments

The LSP spec doesn't specify in what order semantic tokens should be returned (i.e. from highest -> smallest index or smallest -> highest index). This is causing issues in Razor and Roslyn, since on the Razor side we're having to reverse the results returned by Roslyn. Once the LSP spec specifies ordering, we should explore solutions for getting rid of the .Reverse calls to improve perf.

See https://github.com/dotnet/aspnetcore-tooling/pull/4092#discussion_r688822784 for additional details.

allisonchou avatar Aug 16 '21 21:08 allisonchou

Here's the issue on LSP to clarify: https://github.com/microsoft/language-server-protocol/issues/1333.

ryanbrandenburg avatar Aug 16 '21 22:08 ryanbrandenburg

@allisonchou / @ryanbrandenburg do we still need this issue?

NTaylorMullen avatar Jul 27 '22 23:07 NTaylorMullen

We do not. The "Semantic Tokens Delta" code is not present in the Razor repo anymore.

phil-allen-msft avatar Jan 30 '24 23:01 phil-allen-msft