Alkis Evlogimenos
Alkis Evlogimenos
Thanks Eugene!
I have been super busy the last couple of weeks. It will probably take a week for me to find some time to take a look. On Wed, May 17,...
Finally I found some time to take a look. I think this added complexity is not necessary. One can parse numbers in a lossy way by defining two structs: one...
Can't the user provide a deserialize_with= function on their own? It shouldn't be too hard. Do you want to add lossless integer conversion?
Just some more thoughts on this. When you work with decimal, it is usually because you know floating point does not work for you. So we can assume the user...
I think for int64/f64 we will need to convert them into BCD8 and call decQuadFromBCD. int64 should be exact, f64 will be lossy. Do you want to take a stab...
Thanks for the contribution @trolleyman. Give me a week to carve some time to take a closer look.
Thanks for the contribution! In addition to the comments above: don't we need some tests?
It looks like with the new [Macros 1.1](https://github.com/rust-lang/rfcs/blob/master/text/1681-macros-1.1.md) this should be even easier. Do you want to take a stab at it?
If you do the unsafe approach (union of u32 and T) it is super fast. I have this implementation internally and you can't really beat it.