Alkis Evlogimenos comments

Results 34 comments of


                                            Alkis Evlogimenos

sin() / cos() / tan() methods

Unfortunately the underlying API does not support these ops so it is not easy to add. If you can provide implementations I would be happy to review them. That aside...

Use void to indicate that parsing will never return an Err

It seems the `!` type is stabilized for this usecase. Do you want to update the PR?

Adds truncate, half-up rounding functions

@jonathanstrong do you want to make this merge cleanly so that it can be merged? Then we can push a new version out.

Adds truncate, half-up rounding functions

I think we can merge the whole thing. I also sent you an invite to commit directly if that helps.

Adds truncate, half-up rounding functions

If you are happy to do it in smaller steps that would be even better.

Adds truncate, half-up rounding functions

Will do. Thanks @jonathanstrong!

Incorrect formatting

Thanks for the report! Care to provide a patch? Perhaps instead of `fmt.pad` we should use `fmt.pad_integral` to ignore precision? Would that work on all cases?

Add d128::quantize_with_mode function

I think it is better if we make the context a bit more ergonomic and then this function won't be necessary. How about a public function `with_mode` that is a...

Add d128::quantize_with_mode function

I think `with_mode` gives you a lot of power and with it come some rough edges you need to think about. The nice thing about it is that the user...

Implement num traits for d128

It would but it seems like a lot of work. Is there a use case for it? Maybe you want to provide a PR?