Alex | Interchain Labs
Alex | Interchain Labs
Tried to update the branch and created a merge error - my bad Fixed [3fa6677](https://github.com/ignite/cli/pull/2669/commits/3fa66779ed22a9eac6aa9a7c998e4e6035f203b3)
Not sure why it's failing now EDIT: It was because of the added `node` commands - fixed
> wdyt about following the `transfer` module pattern and having a separate `IBCModule` type: > > https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/ibc_module.go#L21-L30 > > and `AppModuleBasic` type: > > https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/module.go#L33 > > This is how...
> wdyt about following the `transfer` module pattern and having a separate `IBCModule` type: > > https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/ibc_module.go#L21-L30 > > and `AppModuleBasic` type: > > https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/module.go#L33 > > This is how...
#2702 and #2703 are open
Any remaining issues with this PR?
The circular dependency caused by chains importing `ignite-cli` (for cosmoscmd) and `ignite-cli` importing `spn` is the main trouble point with this upgrade to newer SDK versions with lots of API-breaking...
Can we close this?
Hey @faddat overall looks good to me. Can we not include the `.gitpod` file in this PR?
closing due to lack of activity