spn icon indicating copy to clipboard operation
spn copied to clipboard

chore: dependency and lint bump

Open faddat opened this issue 3 years ago • 2 comments

Closes #. in case of a bug fix, this should point to a bug or any other related issue(s)

What does this PR do?

  • ensures that we don't import versions below sdk v0.46.0

How to test?

  • make a 46 chain with ignite or try to upgrade a 45 chain with ignite

Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Include tests (N/A)
  • [ ] Respect code style and lint (hope so)
  • [ ] Update documentation (*.md) (if needed) (should not be needed)

faddat avatar Sep 02 '22 17:09 faddat

Codecov Report

Merging #946 (d75a8e5) into develop (c65411c) will decrease coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #946      +/-   ##
===========================================
- Coverage    10.75%   10.74%   -0.01%     
===========================================
  Files          280      280              
  Lines        67161    67161              
===========================================
- Hits          7220     7217       -3     
- Misses       59780    59782       +2     
- Partials       161      162       +1     
Impacted Files Coverage Δ
x/campaign/simulation/store.go 82.43% <0.00%> (-2.03%) :arrow_down:

codecov[bot] avatar Sep 02 '22 17:09 codecov[bot]

Hey @faddat overall looks good to me. Can we not include the .gitpod file in this PR?

aljo242 avatar Sep 02 '22 17:09 aljo242

closing due to lack of activity

aljo242 avatar Sep 30 '22 15:09 aljo242