cli
cli copied to clipboard
feat: upgrade Cosmos SDK to v0.46.0 and IBC to v5
Not sure why it's failing now
EDIT: It was because of the added node
commands - fixed
wdyt about following the transfer
module pattern and having a separate IBCModule
type:
https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/ibc_module.go#L21-L30
and AppModuleBasic
type:
https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/module.go#L33
This is how it could potentially look like:
https://github.com/fadeev/templateIBCv4/tree/master/x/foobar
wdyt about following the
transfer
module pattern and having a separateIBCModule
type:https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/ibc_module.go#L21-L30
and
AppModuleBasic
type:https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/module.go#L33
This is how it could potentially look like:
https://github.com/fadeev/templateIBCv4/tree/master/x/foobar
Yeah, I like this pattern and it would be relatively easy to add !
wdyt about following the
transfer
module pattern and having a separateIBCModule
type:https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/ibc_module.go#L21-L30
and
AppModuleBasic
type:https://github.com/cosmos/ibc-go/blob/v5.0.0-beta1/modules/apps/transfer/module.go#L33
This is how it could potentially look like:
https://github.com/fadeev/templateIBCv4/tree/master/x/foobar
Added :)
wdyt about adding interchain accounts to the default template?
wdyt about adding interchain accounts to the default template?
I think like IBC transfer, it should be part of the default template as general purpose application of IBC
I would suggest creating an issue and handling it in a separated PR
#2702 and #2703 are open
Visit the preview URL for this PR (updated for commit b1c9d12):
https://ignite-go-docs--pr2677-feat-sdk-ibc-upgrade-78213w5i.web.app
(expires Tue, 23 Aug 2022 13:32:55 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Any remaining issues with this PR?
Great! Thanks everyone for making this happen!
@jeronimoalbi, @lubtd would you be able to give a review before we merge?