Alexander Wang

Results 443 comments of Alexander Wang

I think https://github.com/terrastruct/d2/issues/12 is a pre-req to this. Once connections have icons, `animated: true` can animate the icon instead of dashed line.

https://play.d2lang.com/?script=qlDQtVOotFKo5lJQUFZwyU8tVsjLL8nIzEvnUlDITM7Ps1LIKCkpKLbS1wfxivVKUouKEotLikqTS_SS83P1U4uLU_NKMhNzilWN3IwMjXUTcxKLcvWKy9K5arm4qmAml-cXZRdTw0hAAAAA__8%3D&

Yeah I know a label can do that, but I think it'd be common for users to want a label AND an icon while animating. So I don't want to...

Why introduce a new keyword? Adding a third keyword here means you expect someone to have a label, icon, AND an animated text. That's bloated

@danielsuh05 Yes, you just have to specify the position, the renderer already has logic to move labels to their predefined position. Although I do think it's a little too involved,...

@bo-ku-ra You do have a point that animating some text might be what people want instead of icon. Maybe `animated: icon` or `animated: label` for connections to specify

Oops I did not realize the ball was in my court for reviewing. Sorry @danielsuh05 . I'm not sure if you've moved on. No worries if so I can take...

@danielsuh05 Let me know if you'd like me to take over

yes, since that's the universal link color. But if you want it different, please make an issue

@DeflateAwning ty! oh interesting, 3d hexagon could look cool. rounded rect and diamond you can do: https://play.d2lang.com/?script=qrBSqOZSUACbpIcSKVYKply1XGk5-eVQJSBfWSmkZCbm5uelcNVyAQIAAP__& what's the case for octagon that hexagon doesn't cover?